allow more mappings per mapname #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristofvandam
force-pushed
the
kv/multi_ident_mapnames
branch
from
609d3df to
8f98d71
Compare
It is perfectly fine have more mappings per mapname, [ref](https://www.postgresql.org/docs/current/auth-username-maps.html). The current implementation doesn't allow repetitions of mapnames in `pg_ident.conf`, with this change an entry is unique based on map_name, system_username and database_username. This allows for multiple system users to be mapped to a single database user.
kristofvandam
force-pushed
the
kv/multi_ident_mapnames
branch
3 times, most recently
from
bf02aed to
d25ebd4
Compare
bmhughes
added
Feature Request
Contributor
Author
|
would fix #787 |
kristofvandam
force-pushed
the
kv/multi_ident_mapnames
branch
from
d25ebd4 to
e34804e
Compare
damacus
previously approved these changes
Jun 21, 2025
Member
|
Looks like we got a small test error. Ping me when this is fixed 👌 Thanks! |
mdl doesn't like url's that are not clickable, but for the sake of defining a default value for a resource, we can ignore this error.
kristofvandam
force-pushed
the
kv/multi_ident_mapnames
branch
from
e34804e to
b15c741
Compare
when the mapname (or any other field in the ident file) exceeds the predefined width, the values are 'glued' together. This renders the file invalid. similar like this issue: sous-chefs#733 we now force a space between the values if the exceed the column width.
kristofvandam
force-pushed
the
kv/multi_ident_mapnames
branch
from
9121f03 to
a21353f
Compare
Contributor
Author
|
Some tests are failing due to chef/chef#15048. Without that fix i will be unable to fix the tests, after that fix i'll look into the rest. I'm mainly testing against ident-17-debian-12, there the tests are succeeding (works on my machine 😅 ) |
Contributor
|
The indempotency issues we can ignore for now, but there are a large number of ident tests failing too which would suggest that this PR has either broken something or the tests need updating to match the new behaviour. If we can get those sorted then this can be merged 👍 |
Member
|
There are a few things wrong here. So I'm going to bring them into the multi_ident_mapnames branch and fix them there. 👍🏼 |
damacus
merged commit 69058e7
into
sous-chefs:multi_ident_mapnames
77 of 146 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is perfectly fine have more mappings per mapname, ref.
The current implementation doesn't allow repetitions of mapnames in
pg_ident.conf, with this change an entry is unique based on map_name, system_username and database_username.This allows for multiple system users to be mapped to a single database user.
Issues Resolved
No issue was created regarding tis PR
Check List
## Unreleased